Repository navigation
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev/1.3 #18931 +/- ##
=============================================
+ Coverage 45.51% 45.52% +0.01%
Complexity 198 198
=============================================
Files 3667 3667
Lines 251270 251296 +26
Branches 31130 31128 -2
=============================================
+ Hits 114361 114403 +42
+ Misses 136909 136893 -16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport #18917 (8a8a6da) to
dev/1.3.Use an incremental estimator for aligned page memory so adding a value chunk does not repeatedly scan all previously cached chunks. Reuse the accumulated estimates when constructing the aligned chunk reader.
Adapt the implementation to the
container/scanpackage and the TsFile APIs ondev/1.3. The regression test usesAlignedChunkMetadata,List<MeasurementSchema>, the single-argumentgetAlignedChunkMetadatamethod, and an explicitTablet.rowSize.Validation
mvn -o -Ddevelocity.off=true spotless:apply -pl iotdb-core/datanode: passed.javac --release 17, using the resolveddev/1.3dependencies (TsFile1.1.4-260130-SNAPSHOT). RanAlignedPageMemoryUsageEstimatorTestwith JUnitCore: passed, 1 test.getAllActivationStatus,getLicenseInfo, andfetchIoTConsensusProgress).This PR has: