Repository navigation
[Fix] Preserve IoTConsensusV2 replication for split LOAD TsFiles - #18927
Merged
Merged
Conversation
jt2594838
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split LOAD transactions write to a region's write peer but retain progress generated by the coordinator. When those nodes differ, IoTConsensusV2 filters the imported TsFile out of replication because its progress contains no local node ID. Even with a local coordinator, progress allocated before PREPARE can fall behind intervening writes. Other replicas can therefore miss imported data, including after cluster restart.
Assign fresh receiving-node progress when COMMIT imports each staged TsFile, and serialize it into the resource file before publishing the import. Other consensus protocols retain the prepared progress. Regression tests check replication eligibility after resource recovery, ordering after an intervening write, and the non-V2 behavior.
Validation
LoadTsFileManagerTest,LoadTsFileTableSchemaTest, andLoadTsFileResumeTest: 34 tests passed.IoTDBPipeDataSinkIT#testSinkTsFileFormat10andIoTDBPipeLifeCycleIT#testDoubleLiving: both passed with dual IoTConsensusV2 Batch clusters and again with dual Stream clusters (4 IT executions, including both cluster restarts).git diff --checkpassed.