Repository navigation
Conversation
…pache#18904) Backport only the historical TsFile/mod reference fix. Adapt to the 1.3 ModificationFile API and use the same creation-time-qualified pipe directory for historical selection and events. (cherry picked from commit 10c5f89)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When compaction removes an original TsFile and its mods after historical selection, a pipe can lose deletion filtering or fail to acquire the event's file references. Backport the historical TsFile/mod preservation fix from #18904 (10c5f89) to
dev/1.3.dev/1.3for the event to find the pinned files after compaction.Backport scope and adaptation
PipeHistoricalDataRegionTsFileSourceand the legacyModificationFile/.modsAPI.dev/1.3implementation.Validation
mvn -nsu spotless:apply -pl iotdb-core/datanodepassed.mvn -nsu test -pl iotdb-core/datanode -am -Dtest=PipeTsFileInsertionEventTest,PipeTsFileResourceManagerTest,PipeHistoricalDataRegionTsFileSourceTest -Dsurefire.failIfNoSpecifiedTests=false -DfailIfNoTests=false -Dcheckstyle.skip=truepassed, including the dependency reactor build.git diff --checkpassed.This PR has:
Key changed classes
PipeTsFileInsertionEventPipeTsFileResourceManagerPipeHistoricalDataRegionTsFileSource