Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Aligned TsFile page-memory estimation reparsed every already cached value chunk whenever a new value chunk was considered. For wide aligned devices this made the scan parser's work quadratic in the number of value chunks and could leave pipe history threads at 100% CPU for hours.
Changes
Validation
mvn spotless:check -pl iotdb-core/datanodeJUnitCore:OK (1 test)The full Maven test invocation was attempted but could not complete because the local machine was already under heavy Java-process memory pressure; the JVM first failed to reserve memory and the reduced-heap retry remained in the existing module compilation for several minutes without producing a result.