Repository navigation
Conversation
Treat the default IoTConsensus V1 WAL watermark as unconfirmed replication in both retention and the staged-directory cleaner. Keep immediate release for V2 and protocols without a V1 WAL. Cover commit payload readability, terminal task recovery, and cleanup before the first watermark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
STOP PIPEfinishes while a ConfigNode task is blocked insource.supply(), the task can still transfer events created afterward. This causesIoTDBPipeLifeCycleIT.testLifeCycleWithHistoryDisabledto seeroot.ln0on the receiver while the Pipe is stopped.Check the stop flag before polling and again after the source returns. Keep a fetched event in
lastEventso restarting the Pipe transfers and commits it once. If the task was dropped during polling, release the fetched event without committing it.Add deterministic regression tests for a stopped task, stopping during a blocked poll followed by restart, and dropping during a blocked poll.
Validation
PipeConfigNodeSubtaskTestandPipeConfigNodeSubtaskExecutorTest: 8 tests passed.IoTDBPipeLifeCycleIT#testLifeCycleWithHistoryDisabled: passed with twoScalableSingleNodeModeclusters using the rebuilt ConfigNode jar. The initial local attempt exhausted Windows committed memory during node startup; the rerun passed with bounded JVM heaps.git diff --checkpassed.