Repository navigation
[Test] Fix deletion regression test flush control - #18888
Merged
jt2594838 merged 1 commit intoOct 15, 2026
Merged
Conversation
hongzhi-gao
approved these changes
Oct 15, 2026
hongzhi-gao
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the close/flush callback sequence and the assertions in the affected deletion regression tests. No blocking code-review findings. My local targeted run did not reach tests because of stale cross-module build artifacts; DataNode unit-test CI is still pending, so please wait for it before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The deletion regression tests set
managedByFlushManagerbefore callingasyncClose(), so its guard returns before queuing the working memtable. This breaks both deletion WAL tests and causes a null-future exception during cleanup of the flush-completion test.Claim manual flush control in the flush-time callback, after the close guard and before FlushManager registration. This lets the tests exercise the production close path while retaining control over flush execution and checking deletion persistence.
Validation
TsFileProcessorTest— 26 tests passed.mvn spotless:apply -pl iotdb-core/datanode— passed.git diff --check origin/master...HEAD— passed.This PR has:
Key changed classes
TsFileProcessorTest