Repository navigation
[Test] Wait for asynchronous table deletion in session IT - #18877
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
IoTDBSessionRelationalIT.dropTableOfTheSameNameTestassumes thatDROP TABLEfinishes deletion before returning. With asynchronous deletion, the next query can receive555: ... pre-delete stateinstead of the expected550: Table 'db2.table16' does not exist.Poll the existing table-not-found assertion with Awaitility for up to 60 seconds, using the session's thread and closing any successful query result while waiting. Check that the same-named table in
db1retains its original data after thedb2table is gone. A deletion that never completes still fails the test.Validation
mvn spotless:apply -pl integration-test -Pwith-integration-testspassed (scoped to the changed file).mvn package -DskipTests -pl integration-test -am -Pwith-integration-tests -Ddevelocity.off=truepassed, rebuilding the test nodes and compiling the integration tests. Checkstyle and Spotless passed during the build.mvn failsafe:integration-test@integration-test failsafe:verify@verify -pl integration-test -PTableSimpleIT -Pwith-integration-tests -Dit.test=IoTDBSessionRelationalIT#dropTableOfTheSameNameTest -DfailIfNoTests=true -Ddevelocity.off=truepassed: 1 test, 0 failures/errors/skips (1 ConfigNode, 1 DataNode).-PTableClusterITpassed: 1 test, 0 failures/errors/skips (1 ConfigNode, 3 DataNodes).Local Maven runs used a bounded heap (
-Xmx2048mfor packaging and-Xmx1024mfor Failsafe) and-XX:ActiveProcessorCount=4. The fullverifylifecycle was stopped when RAT stalled scanning local Git ignore rules; the package build and targeted Failsafe verification above completed successfully.This PR has:
Key changed classes
IoTDBSessionRelationalIT