Repository navigation
Conversation
jt2594838
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Subscription events currently share the server-wide recycle timeout, which defaults to 600 seconds. Add the topic attribute
recycle-uncommitted-event-interval-msso each topic can override this timeout with a long value in milliseconds. Positive values enable recycling after the timeout; zero or negative values disable automatic recycling. Explicit NACK redelivery and ACK commits remain available. Topics without the attribute continue to usesubscription_recycle_uncommitted_event_interval_ms, which also disables automatic recycling when set to zero or a negative value.The attribute supports CREATE TOPIC and ALTER TOPIC across topic modes and response formats. Both Pipe and Consensus subscription queues apply updates to existing in-flight events, and Consensus queues wake when the setting changes without scheduling recycle retries while recycling is disabled. Runtime overrides are isolated by topic name and data model; metadata snapshot updates preserve existing overrides while they are being applied.
Validation
mvn -nsu test-compile -DskipTests -P with-zh-locale.git diff --check.This PR has:
Key changed classes
TopicConfig,SubscriptionInfo,SubscriptionTopicAgent,SubscriptionPrefetchingQueue,ConsensusPrefetchingQueue, andSubscriptionEvent.