Repository navigation
[Performance] Pre-size collections with known cardinality - #18851
Merged
Merged
Conversation
JackieTien97
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Several collection materialization paths already know how many entries they will append, but allocate default-sized containers. Large batches repeatedly grow and copy
ArrayListbacking arrays or resize hash tables.Pre-size 132 collections in 74 production Java files across eight modules:
Use serialized entry counts or the exact number of outputs produced from the input. Keep optional empty lists at capacity zero and preserve their existing null/empty handling. Hash maps and sets use the existing Guava expected-size factories, which account for the default load factor and avoid capacity arithmetic overflow.
This is independent of #18845; its WAL metadata and subscription acknowledgement changes are not included.
Validation
test-compilepassed for the eight affected modules and their dependencies (30 modules).test-compilepassed for the same 30 modules with-P with-zh-locale.A separate JDK 17 allocation experiment used shared, pre-boxed integer entries and
ThreadMXBean.getThreadAllocatedBytesafter warm-up. For constructing and filling 1,024 entries:These are container allocation measurements; cluster throughput has not been benchmarked.