Skip to content

Optimize subscription WAL acknowledgement path - #18845

Open
Caideyipi wants to merge 3 commits into
masterfrom
fix/subscription-wal-prefetch-hotspots
Open

Optimize subscription WAL acknowledgement path#18845
Caideyipi wants to merge 3 commits into
masterfrom
fix/subscription-wal-prefetch-hotspots

Fix subscription ACK cleanup ordering

abef0a8
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Oct 23, 2026 in 5m 32s

Quality Gate failed

Failed conditions
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 1620 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/schema/ClusterSchemaManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'MetadataException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF3Tfopp2EifT74KN&open=AaFnF3Tfopp2EifT74KN&pullRequest=18845

Check failure on line 426 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/table/DataNodeTableCache.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Fix this access that will throw a NullPointerException when executed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF2UGopp2EifT74Jl&open=AaFnF2UGopp2EifT74Jl&pullRequest=18845

Check warning on line 25 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/view/TreeToTableViewReference.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this class declaration to use 'record TreeToTableViewReference(String databaseName, String tableName, boolean ...)'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF2RDopp2EifT74JX&open=AaFnF2RDopp2EifT74JX&pullRequest=18845

Check warning on line 94 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the "new String[]" prefix; the declaration already specifies the array type. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF2oCopp2EifT74J6&open=AaFnF2oCopp2EifT74J6&pullRequest=18845

Check warning on line 2218 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof ProjectNode project' 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF1pgopp2EifT74I-&open=AaFnF1pgopp2EifT74I-&pullRequest=18845

Check warning on line 228 in iotdb-client/cli/src/main/java/org/apache/iotdb/tool/common/Constants.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 174). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF37topp2EifT74Ki&open=AaFnF37topp2EifT74Ki&pullRequest=18845

Check warning on line 19 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/table/TreeToTableViewCache.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

'package' should be separated from previous line. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF2RRopp2EifT74JY&open=AaFnF2RRopp2EifT74JY&pullRequest=18845

Check warning on line 62 in iotdb-core/datanode/src/main/java/org/apache/tsfile/write/BufferedFileChannelOutput.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'IllegalArgumentException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF2zyopp2EifT74J_&open=AaFnF2zyopp2EifT74J_&pullRequest=18845

Check warning on line 2772 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/memtable/TsFileProcessor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invert this negated condition and swap the two branches of the ternary. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF1K1opp2EifT74Iq&open=AaFnF1K1opp2EifT74Iq&pullRequest=18845

Check warning on line 2210 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof AggregationNode aggregation' 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF1pgopp2EifT74I9&open=AaFnF1pgopp2EifT74I9&pullRequest=18845

Check warning on line 1733 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/schema/ClusterSchemaManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF3Tfopp2EifT74KH&open=AaFnF3Tfopp2EifT74KH&pullRequest=18845

Check warning on line 100 in iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/execution/operator/process/CollectOperator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused method parameter "childId". 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF27Lopp2EifT74KF&open=AaFnF27Lopp2EifT74KF&pullRequest=18845

Check failure on line 466 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/splitter/AlignedChunkData.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use try-with-resources or close this "ByteBufferOutputStream" in a "finally" clause. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF1c4opp2EifT74I1&open=AaFnF1c4opp2EifT74I1&pullRequest=18845

Check failure on line 551 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF3XNopp2EifT74KU&open=AaFnF3XNopp2EifT74KU&pullRequest=18845

Check warning on line 898 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ProgressWALIterator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Invert this negated condition and swap the two branches of the ternary. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF2eSopp2EifT74Jw&open=AaFnF2eSopp2EifT74Jw&pullRequest=18845

Check warning on line 355 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/TreeDeviceViewFieldDetector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 126). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF3ivopp2EifT74Ka&open=AaFnF3ivopp2EifT74Ka&pullRequest=18845

Check warning on line 193 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/TreeDeviceViewFieldDetector.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'SemanticException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF3ivopp2EifT74KZ&open=AaFnF3ivopp2EifT74KZ&pullRequest=18845

Check warning on line 228 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/table/TreeToTableViewCache.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Single-line Javadoc comment should be multi-line. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF2RRopp2EifT74Jb&open=AaFnF2RRopp2EifT74Jb&pullRequest=18845

Check failure on line 2197 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/distribute/TableDistributedPlanGenerator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF1pgopp2EifT74I8&open=AaFnF1pgopp2EifT74I8&pullRequest=18845

Check warning on line 83 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/splitter/TsFileSplitter.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this private field "final", it is never reassigned. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF1Wcopp2EifT74I0&open=AaFnF1Wcopp2EifT74I0&pullRequest=18845

Check warning on line 426 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/memory/MemoryPool.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 120). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF2Aaopp2EifT74JO&open=AaFnF2Aaopp2EifT74JO&pullRequest=18845

Check warning on line 237 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make this private field "final", it is never reassigned. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF3XNopp2EifT74KR&open=AaFnF3XNopp2EifT74KR&pullRequest=18845

Check warning on line 684 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/memory/MemoryPool.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 116). 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF2Aaopp2EifT74JQ&open=AaFnF2Aaopp2EifT74JQ&pullRequest=18845

Check warning on line 55 in iotdb-client/cli/src/main/java/org/apache/iotdb/tool/common/ImportTsFileOperation.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Expected @throws tag for 'FileAlreadyExistsException'. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF35Ropp2EifT74Kf&open=AaFnF35Ropp2EifT74Kf&pullRequest=18845

Check warning on line 1740 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/schema/ClusterSchemaManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this TODO comment. 

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaFnF3Tfopp2EifT74KI&open=AaFnF3Tfopp2EifT74KI&pullRequest=18845
View more details on SonarQubeCloud