Repository navigation
Conversation
Caideyipi
force-pushed
the
refactor/align-shared-pipe-consensus-subscription
branch
from
October 26, 2026 10:40
7a22815 to
5cb1d22
Compare
Collaborator
Author
|
Self-review passed. I reviewed the complete diff and relevant surrounding code. No actionable issues were found, so no fixes were needed. Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor shared Pipe, IoTConsensus, and subscription code into focused interfaces and helpers while preserving existing behavior.
PipeBatchMetricsSettableand extract batch detachment while keeping synchronization and atomic ownership handoff intact.TableViewTabletProjectorProvider, reusing the existing schema preparation logic and the batch's immutable topic configuration. Keep projector lifetime scoped to each batch and preserve TAG filtering, column pruning, and WAL replay behavior.Existing constructors and metric setters remain available. Regression coverage includes missing consensus groups, schema availability, projector lifetime, topic changes between capture and emission, and TAG filters without tree capture.
Validation
mvn clean package -DskipTestspassed for both the default locale and-P with-zh-locale. Each build used a fresh source tree and a separate empty Maven repository, with Maven and Develocity build caches disabled.with-integration-tests, Checkstyle, andgit diff --checkpassed.This PR has: