Repository navigation
Retry failed procedure rollback without losing state - #18822
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rollback fails after a procedure has persisted its state, the executor currently discards the rollback state and completes the procedure, so recovery cannot retry compensation. Add an opt-in rollback retry timeout, retain the failed state across serialization, and preserve the original execution failure. Also report pre-submission procedure conflicts immediately when the procedure still has NO_PROC_ID. Tests cover retry after transient rollback failures, serialization, and the pre-submission status.