Repository navigation
Conversation
Caideyipi
force-pushed
the
fix/pipe-compaction-queue-replacement
branch
from
October 23, 2026 09:20
d207c17 to
29a3153
Compare
Collaborator
Author
|
Self-review passed. Fixed the compaction sink setting so sink.enable-compaction=false (and the compatibility default for restored Pipes) now prevents queue replacement even when real-time-first scheduling is enabled. The queue still prioritizes real-time events independently, while only explicitly enabled user Pipes perform compaction replacement; the no-arg queue keeps internal Pipes disabled by default. Added a regression test for the disabled-by-default case. Verification: mvn spotless:apply -pl iotdb-core/datanode passed; focused DataNode reactor tests passed (14 tests, 0 failures/errors): PipeRealtimePriorityBlockingQueueTest and PipeDataNodeTaskBuilderTest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Match the actual compaction source files
PipeTsFileInsertionEvents by normalized original TsFile paths instead of only comparing event counts.TsFileResourcepath after an event creates a hard link in its Pipe directory.Roll out through a Pipe sink parameter
sink.enable-compaction(and itsconnector.enable-compactionalias) as a Pipe-scoped setting rather than a global configuration.sink.enable-compaction=truewhen a new user Pipe is created without an explicit value.falsewhen restored existing Pipe metadata does not contain the setting.Concurrency and performance
This keeps the synchronization cost off the normal Pipe sending path. The accepted tradeoff is a small duplicate-delivery window during a compaction/poll race, while avoiding data loss and reference-count corruption.
Tests
BUILD SUCCESS.IoTDBPipeCompactionSinkParameterITran independently: 1 test, 0 failures, 0 errors, 0 skipped.This PR has:
Key changed/added classes in this PR
CreatePipeProcedureV2PipeDataNodeTaskBuilderPipeRealtimePriorityBlockingQueuePipeTsFileInsertionEventCreatePipeProcedureV2TestPipeDataNodeTaskBuilderTestPipeRealtimePriorityBlockingQueueTestIoTDBPipeCompactionSinkParameterIT