Repository navigation
Pipe: add IoTDBSink sender port configuration - #13593
Open
luoluoyuyu wants to merge 49 commits into
Open
luoluoyuyu wants to merge 49 commits into
luoluoyuyu wants to merge 49 commits into
Conversation
luoluoyuyu
marked this pull request as draft
September 23, 2024 14:34
luoluoyuyu
marked this pull request as ready for review
September 25, 2024 08:27
Caideyipi
reviewed
Sep 26, 2024
luoluoyuyu
marked this pull request as draft
September 29, 2024 07:00
luoluoyuyu
marked this pull request as ready for review
September 29, 2024 09:24
Caideyipi
approved these changes
Sep 29, 2024
SteveYurongSu
marked this pull request as draft
October 12, 2024 11:58
luoluoyuyu
marked this pull request as ready for review
October 14, 2024 02:44
SteveYurongSu
marked this pull request as draft
October 18, 2024 03:30
luoluoyuyu
marked this pull request as ready for review
October 22, 2024 07:13
luoluoyuyu
marked this pull request as draft
October 22, 2024 07:13
# Conflicts: # integration-test/src/test/java/org/apache/iotdb/pipe/it/dual/treemodel/auto/basic/IoTDBPipeConnectorCustomPortIT.java # iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/sink/client/IoTDBConfigNodeSyncClientManager.java # iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/sink/protocol/IoTDBConfigRegionSink.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/async/IoTDBDataRegionAsyncConnector.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBDataNodeSyncConnector.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/client/IoTDBDataNodeAsyncClientManager.java # iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/sink/client/IoTDBDataNodeSyncClientManager.java # iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/client/ClientPoolFactory.java # iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/client/async/AsyncPipeDataTransferServiceClient.java # iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/sink/client/IoTDBClientManager.java # iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/sink/client/IoTDBSyncClientManager.java # iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/sink/protocol/IoTDBSink.java # iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/sink/protocol/IoTDBSslSyncSink.java
Caideyipi
changed the title
Resolve Pipe sender-port conflicts while preserving master TLS, request slicing, thread-pool naming and overflow-safe client selection. Keep both sides' tests and localize the new port diagnostics.
Collaborator
|
Self-review passed. Fixed configured send-port binding for async and sync pipe clients, prevented async client pools with different send-port ranges from being shared, and tightened send-port validation. Added regression tests for these cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As the title said
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR