IoTDB Edge: stop-edge.bat ignores IOTDB_HOME, while start-edge.bat honours it

start-edge.bat keeps an IOTDB_HOME taken from the environment and passes it to the JVM as -DIOTDB_HOME="...":

iotdb/scripts/sbin/windows/start-edge.bat

Lines 64 to 65 in 7aa8e63

    
           pushd "%~dp0..\.." 
        
           if NOT DEFINED IOTDB_HOME set "IOTDB_HOME=%cd%"

iotdb/scripts/sbin/windows/start-edge.bat

Line 92 in 7aa8e63

set iotdb_parms=%iotdb_parms% -DIOTDB_HOME="%IOTDB_HOME%"

stop-edge.bat always sets IOTDB_HOME to the installation it belongs to, and only stops a java.exe whose command line contains -DIOTDB_HOME= followed by exactly that string:

iotdb/scripts/sbin/windows/stop-edge.bat

Lines 23 to 26 in 7aa8e63

    
           pushd "%~dp0\..\.." 
        
           set "IOTDB_HOME=%cd%" 
        
           popd 
        
           powershell -NoProfile -Command "$ErrorActionPreference='Stop'; $plain='-DIOTDB_HOME=' + $env:IOTDB_HOME; $quoted='-DIOTDB_HOME=' + [char]34 + $env:IOTDB_HOME + [char]34; Get-CimInstance Win32_Process -Filter \"name='java.exe'\" | Where-Object { $line=$_.CommandLine; $sameHome=$line -and ($line.Contains($plain + ' ') -or $line.EndsWith($plain) -or $line.Contains($quoted + ' ') -or $line.EndsWith($quoted)); $sameHome -and $line.Contains('org.apache.iotdb.edge.EdgeNode') } | ForEach-Object { Stop-Process -Id $_.ProcessId -Force; Write-Host ('IoTDB Edge process ' + $_.ProcessId + ' stopped.') }"

So when the node was started with IOTDB_HOME set to another path to the same directory, such as a symbolic link or a junction, stop-edge.bat does not match the process. This is the Windows side of #18545. The Unix scripts are being changed in #18546, where both scripts now derive IOTDB_HOME with one shared function.

This came up in the review of #18546. I do not have a Windows machine and have not run these scripts; the above is from reading them.

Navigation Menu

Repository navigation

IoTDB Edge: stop-edge.bat ignores IOTDB_HOME, while start-edge.bat honours it #19005

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	pushd "%~dp0..\.."
	if NOT DEFINED IOTDB_HOME set "IOTDB_HOME=%cd%"

	pushd "%~dp0\..\.."
	set "IOTDB_HOME=%cd%"
	popd
	powershell -NoProfile -Command "$ErrorActionPreference='Stop'; $plain='-DIOTDB_HOME=' + $env:IOTDB_HOME; $quoted='-DIOTDB_HOME=' + [char]34 + $env:IOTDB_HOME + [char]34; Get-CimInstance Win32_Process -Filter \"name='java.exe'\" \| Where-Object { $line=$_.CommandLine; $sameHome=$line -and ($line.Contains($plain + ' ') -or $line.EndsWith($plain) -or $line.Contains($quoted + ' ') -or $line.EndsWith($quoted)); $sameHome -and $line.Contains('org.apache.iotdb.edge.EdgeNode') } \| ForEach-Object { Stop-Process -Id $_.ProcessId -Force; Write-Host ('IoTDB Edge process ' + $_.ProcessId + ' stopped.') }"

IoTDB Edge: stop-edge.bat ignores IOTDB_HOME, while start-edge.bat honours it #19005

Description

Activity

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions