refactor(metadata): add typed return values to state handlers #2714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2714 +/- ##
============================================
+ Coverage 68.30% 68.45% +0.14%
Complexity 585 585
============================================
Files 734 735 +1
Lines 59764 59863 +99
Branches 56177 56276 +99
============================================
+ Hits 40822 40979 +157
+ Misses 16955 16893 -62
- Partials 1987 1991 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
StateHandler returned void, preventing commands from producing results through the left-right layer. Introduce CommandEnvelope to smuggle typed return values out of Absorb's void interface. - StateHandler and Command now carry an Output associated type - WriteCell gains a debug-mode reentrancy guard - LeftRight exposes with_state() for lock-free reads - Timestamps captured once before entering left-right for deterministic replay across both copies - Mux base case panics on unhandled commands instead of silent drop - Add integration tests for stream/user creation and mux fallthrough
mod.rs mixed traits, unsafe left-right infra, and code-gen macros in a single 400-line file, making each concern hard to review independently. Split into focused modules: - traits.rs: StateHandler, Command, State, StateMachine - left_right.rs: CommandEnvelope, WriteCell, LeftRight - macros.rs: define_state!, collect_handlers! - mod.rs: module declarations and re-exports Add bytemuck and bytes as dev-dependencies for test message construction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mod.rs mixed traits, unsafe left-right infra, and code-gen macros in a single 400-line file, making each concern hard to review independently. StateHandler also returned void, preventing commands from producing results through the left-right layer.
Split into focused modules (traits.rs, left_right.rs, macros.rs) and introduce CommandEnvelope to smuggle typed return values out of Absorb's void interface. StateHandler and Command now carry an Output associated type. WriteCell gains a debug-mode reentrancy guard and LeftRight exposes with_state() for lock-free reads.