Skip to content

Conversation

@hubcio
Copy link
Contributor

@hubcio hubcio commented Feb 9, 2026

Split define_state! into define_state! (struct + wrapper) and collect_handlers! (enum, Command, dispatch, Absorb). Each command type now implements StateHandler<S> for the state it mutates, moving handler logic from a central match block onto the command.

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 0.65789% with 302 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.01%. Comparing base (85d73ca) to head (cde70cc).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
core/metadata/src/stm/stream.rs 0.00% 149 Missing ⚠️
core/metadata/src/stm/user.rs 0.00% 87 Missing ⚠️
core/metadata/src/stm/consumer_group.rs 0.00% 48 Missing ⚠️
core/metadata/src/stm/mod.rs 10.00% 17 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2705      +/-   ##
============================================
+ Coverage     67.88%   69.01%   +1.12%     
============================================
  Files           734      571     -163     
  Lines         59374    55540    -3834     
  Branches      55787    55540     -247     
============================================
- Hits          40309    38330    -1979     
+ Misses        17108    15337    -1771     
+ Partials       1957     1873      -84     
Flag Coverage Δ
java ?
rust 69.01% <0.65%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
core/metadata/src/stm/mod.rs 41.79% <10.00%> (-4.12%) ⬇️
core/metadata/src/stm/consumer_group.rs 0.00% <0.00%> (ø)
core/metadata/src/stm/user.rs 0.00% <0.00%> (ø)
core/metadata/src/stm/stream.rs 0.00% <0.00%> (ø)

... and 168 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…dispatch

Split define_state! into define_state! (struct + wrapper) and
collect_handlers! (enum, Command, dispatch, Absorb). Each command
type now implements StateHandler<S> for the state it mutates,
moving handler logic from a central match block onto the command.

Removes Handler trait and impl_absorb! macro. All 19 handlers
migrated (10 stream, 7 user, 2 consumer_group).
@hubcio hubcio force-pushed the invert-state-handler-dep branch from 3e8c098 to 85cc519 Compare February 9, 2026 15:25
@spetz spetz merged commit f78a93d into master Feb 10, 2026
39 checks passed
@spetz spetz deleted the invert-state-handler-dep branch February 10, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants