-
Notifications
You must be signed in to change notification settings - Fork 262
feat(connectors): fix state & memory leak, test all plugins, enrich sinks #2685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2685 +/- ##
============================================
+ Coverage 67.87% 68.61% +0.73%
Complexity 637 637
============================================
Files 734 734
Lines 59389 59660 +271
Branches 55802 56073 +271
============================================
+ Hits 40310 40933 +623
+ Misses 17119 16727 -392
- Partials 1960 2000 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
mmodzelewski
previously approved these changes
Feb 5, 2026
hubcio
requested changes
Feb 10, 2026
core/integration/tests/connectors/fixtures/iceberg/container.rs
Outdated
Show resolved
Hide resolved
hubcio
approved these changes
Feb 10, 2026
numinnex
approved these changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
connectors
Connectors runtime
rust
Pull requests that update Rust code
test
New testcase, or improvement of existing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connectors runtime lost state on restart - sink connectors resumed from offset 0 instead of their last committed position. The root cause was twofold: consumer group offset queries required membership (which new runtime instances lacked), and stale members from closed TCP connections blocked partition assignment to new members.
Consumer group offset resolution now supports direct queries without membership for ConsumerGroup consumers, since offsets are stored per group+partition, not per member. Stale member cleanup during join removes members whose client connections no longer exist, enabling proper partition rebalancing.
Runtime architecture refactored to fix memory leaks - replaced centralized status manager with DashMap-based SinkManager and SourceManager. Explicit channel cleanup on shutdown prevents dangling references.
State management uses MessagePack serialization for efficient binary persistence. PostgreSQL source fixed to actually return state from poll() and moved database I/O outside mutex to eliminate lock contention.
Additional changes: