test(connectors): add e2e tests for Elasticsearch sink connector #2684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add end-to-end tests for the Elasticsearch sink connector following the existing test patterns (Quickwit, Postgres). Tests: - given_json_messages_should_index_documents: verifies JSON messages are correctly indexed with original fields preserved - given_bulk_messages_should_index_all: verifies bulk indexing works correctly with 500 messages - given_messages_should_have_iggy_metadata: verifies _iggy_* metadata fields are added to indexed documents Infrastructure: - ElasticsearchContainer: GenericImage-based container with ES 8.17.0, security disabled for testing - ElasticsearchOps trait: common operations (refresh_index, search_all, fetch_documents) - ElasticsearchFixture: TestFixture implementation with auto index creation Closes apache#2592 Signed-off-by: shin <sars21@hanmail.net>
seokjin0414
force-pushed
the
2592-elasticsearch-sink-e2e-tests
branch
from
83aeafe to
af9ce4f
Compare
WaitFor::message_on_stdout("started") alone is insufficient as ES HTTP
API may not be ready to accept connections yet. Add explicit health
check polling /_cluster/health endpoint before returning from start().
Signed-off-by: seokjin0414 <sars21@hanmail.net>
Signed-off-by: shin <sars21@hanmail.net>
seokjin0414
force-pushed
the
2592-elasticsearch-sink-e2e-tests
branch
from
af9ce4f to
c339ce1
Compare
Contributor
|
@seokjin0414 do you plan to rebase this? can you verify if bug still exists? I think its fixed in #2685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2592
Summary
Tests
given_json_messages_should_index_documents- JSON indexing + field verificationgiven_bulk_messages_should_index_all- 500 bulk messagesgiven_messages_should_have_iggy_metadata- iggy* metadata field verificationNote
During testing, discovered a serialization bug in
bulk_index_documentsand reported it as #2683.These tests will pass once that bug is fixed.