-
Notifications
You must be signed in to change notification settings - Fork 261
feat(go): implement Go leader redirection scenario #2580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chengxilo
wants to merge
9
commits into
apache:master
Choose a base branch
from
chengxilo:go_leader_redirection_scenario
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hubcio
approved these changes
Jan 30, 2026
hubcio
reviewed
Jan 30, 2026
Contributor
hubcio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to find someone to review it.
hubcio
requested changes
Feb 3, 2026
123e584 to
03477ba
Compare
hubcio
approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go leader redirection scenario implement
What I did
TransportEndpointsimplementMarshalBinary/UnmarshalBinary(implementencoding.BinaryMarshaler/encoding.Unmarshalerinterface) instead of create a function likeSerializeTransportEndpoints/DeserializeEndpoints. We may replace the previous approach later.Notes
iggyclimust update toclientDeserializeXXX/SerializeXXXwith implmentingMarshalBinary/UnmarshalBinaryin the future.