-
Notifications
You must be signed in to change notification settings - Fork 261
feat(csharp): add iggy error status codes #2519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…pdate error message formatting
…d clean up README.md
…gyInvalidStatusCodeException
|
Hi, I've looked through the PR and I really like the idea, but there is one problem tho... Currently Since the idea is great, I would like to archive this PR and revisit it once we figure out how to extract our error into an dedicated crate, that we can version independently. Created #2524 to address that problem. |
|
yep, it might be good idea for hold on it to time where will be separate crate for IggyError. It can be a bit confusing where error code will change in server. We can also think about some CI checks for thats |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either Thank you for your contribution! |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need a review, please ensure CI is green and the PR is rebased on the latest master. Don't hesitate to ping the maintainers - either @core on Discord or by mentioning them directly here on the PR. Thank you for your contribution! |
IggyErrorCodeenum definitionIggyInvalidStatusCodeExceptionto containsIggyErrorCode