Skip to content

Build: Fix Guava CVE scan failures in GCP and Kafka - #18679

Merged
kevinjqliu merged 2 commits into
apache:mainfrom
manuzhang:codex/fix-guava-cve-packaging
Oct 29, 2026
Merged

kevinjqliu merged 2 commits into
apache:mainfrom
manuzhang:codex/fix-guava-cve-packaging

Conversation

@manuzhang

Copy link
Copy Markdown
Member

CVE-2026-102554 blocks unrelated PRs such as #18678 because the GCP BOM still selects Guava 33.6.0. Select the project's patched Guava explicitly in the GCP bundle; Kafka inherits that dependency. Hadoop's separate shaded copy cannot be upgraded independently and 1.5.0 has no patched successor, so restrict its Kafka exception to that exact jar. The YAML ignore file preserves the existing Parquet exceptions and continues reporting vulnerable Guava in other artifacts.

Test plan: Rebuild GCP/Kafka distributions and scan with Trivy 0.69.3; verify a standalone old-Guava negative control still fails. Both scans, runtime-dependency checks, Spotless, Checkstyle, and 361 GCP/BigQuery/Kafka unit tests passed (28 skipped). Docker integration tests were unavailable; their sources compiled.


AI Disclosure

  • Model: GPT-6
  • Platform/Tool: Codex
  • Human Oversight: unreviewed
  • Prompt Summary: Generate the dependency alignment, runtime baselines, and artifact-scoped Trivy exception to fix the shared GCP/Kafka CI failures.

Use the patched project Guava in cloud dependencies shared by the GCP bundle and Kafka distribution. Restrict the remaining upstream Hadoop shaded-Guava CVE exception to its exact artifact so other vulnerable Guava copies still fail scans.

Generated-by: Codex

Co-authored-by: Codex <codex@openai.com>
@manuzhang
manuzhang force-pushed the codex/fix-guava-cve-packaging branch from 2685025 to b4ff9df Compare October 28, 2026 16:04
@manuzhang
manuzhang marked this pull request as ready for review October 28, 2026 16:05
Use the existing BOM-alignment comment style for the GCP bundle Guava
override, and document the hadoop-shaded-guava exception in the same
format as the other shaded-dependency entries.

Generated-by: GitHub Copilot (Claude Opus 5.5)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

@kevinjqliu kevinjqliu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I pushed a commit (c9de693) to fix the order of the CVE and add a inline comment to explain the gcp-bundle change

Comment on lines +38 to +40
- id: CVE-2026-102554
paths:
- "**/hadoop-shaded-guava-1.5.0.jar"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that the file rename is because only the yaml version supports this syntax:

paths:
- 

com.google.flatbuffers:flatbuffers-java:24.3
com.google.guava:failureaccess:1.0
com.google.guava:guava:33.6
com.google.guava:guava:33.7

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this changed is due to the gcp-bundle/build.gradle change, gcp-bundle is used in kafka-connect/build.gradle:

def gcpBundle = evaluationDependsOn(':iceberg-gcp-bundle')

@kevinjqliu
kevinjqliu merged commit e17f482 into apache:main Oct 29, 2026
41 checks passed
@kevinjqliu

Copy link
Copy Markdown
Contributor

Thanks @manuzhang this should unblock CI

ebyhr pushed a commit to ebyhr/iceberg that referenced this pull request Nov 14, 2026
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Kevin Liu <kevin.jq.liu@gmail.com>
(cherry picked from commit e17f482)
ebyhr pushed a commit to ebyhr/iceberg that referenced this pull request Nov 15, 2026
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Kevin Liu <kevin.jq.liu@gmail.com>
(cherry picked from commit e17f482)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants