Repository navigation
Build: Fix Guava CVE scan failures in GCP and Kafka - #18679
Merged
Merged
Conversation
Use the patched project Guava in cloud dependencies shared by the GCP bundle and Kafka distribution. Restrict the remaining upstream Hadoop shaded-Guava CVE exception to its exact artifact so other vulnerable Guava copies still fail scans. Generated-by: Codex Co-authored-by: Codex <codex@openai.com>
manuzhang
force-pushed
the
codex/fix-guava-cve-packaging
branch
from
October 28, 2026 16:04
2685025 to
b4ff9df
Compare
manuzhang
marked this pull request as ready for review
October 28, 2026 16:05
Use the existing BOM-alignment comment style for the GCP bundle Guava override, and document the hadoop-shaded-guava exception in the same format as the other shaded-dependency entries. Generated-by: GitHub Copilot (Claude Opus 5.5) Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kevinjqliu
approved these changes
Oct 29, 2026
kevinjqliu
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I pushed a commit (c9de693) to fix the order of the CVE and add a inline comment to explain the gcp-bundle change
Comment on lines
+38
to
+40
| - id: CVE-2026-102554 | ||
| paths: | ||
| - "**/hadoop-shaded-guava-1.5.0.jar" |
Contributor
There was a problem hiding this comment.
note that the file rename is because only the yaml version supports this syntax:
paths:
-
kevinjqliu
reviewed
Oct 29, 2026
| com.google.flatbuffers:flatbuffers-java:24.3 | ||
| com.google.guava:failureaccess:1.0 | ||
| com.google.guava:guava:33.6 | ||
| com.google.guava:guava:33.7 |
Contributor
There was a problem hiding this comment.
this changed is due to the gcp-bundle/build.gradle change, gcp-bundle is used in kafka-connect/build.gradle:
iceberg/kafka-connect/build.gradle
Line 70 in a646137
Contributor
|
Thanks @manuzhang this should unblock CI |
ebyhr
pushed a commit
to ebyhr/iceberg
that referenced
this pull request
Nov 14, 2026
Co-authored-by: Codex <codex@openai.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Kevin Liu <kevin.jq.liu@gmail.com> (cherry picked from commit e17f482)
ebyhr
pushed a commit
to ebyhr/iceberg
that referenced
this pull request
Nov 15, 2026
Co-authored-by: Codex <codex@openai.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Kevin Liu <kevin.jq.liu@gmail.com> (cherry picked from commit e17f482)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CVE-2026-102554 blocks unrelated PRs such as #18678 because the GCP BOM still selects Guava 33.6.0. Select the project's patched Guava explicitly in the GCP bundle; Kafka inherits that dependency. Hadoop's separate shaded copy cannot be upgraded independently and 1.5.0 has no patched successor, so restrict its Kafka exception to that exact jar. The YAML ignore file preserves the existing Parquet exceptions and continues reporting vulnerable Guava in other artifacts.
Test plan: Rebuild GCP/Kafka distributions and scan with Trivy 0.69.3; verify a standalone old-Guava negative control still fails. Both scans, runtime-dependency checks, Spotless, Checkstyle, and 361 GCP/BigQuery/Kafka unit tests passed (28 skipped). Docker integration tests were unavailable; their sources compiled.
AI Disclosure