Repository navigation
Fixture: Add reference table input for a data file with partial field IDs - #27
Open
slachiewicz wants to merge 2 commits into
Open
slachiewicz wants to merge 2 commits into
slachiewicz wants to merge 2 commits into
Conversation
slachiewicz
force-pushed
the
partial-field-ids-table
branch
from
November 16, 2026 10:43
abe6cb9 to
b79434a
Compare
A commit's file-schema is written with parquet-mr so a data file can carry column names, order and field IDs the table schema does not, including none on chosen fields; Iceberg's writer always writes every ID.
slachiewicz
force-pushed
the
partial-field-ids-table
branch
from
November 19, 2026 20:45
b79434a to
9542d52
Compare
slachiewicz
marked this pull request as ready for review
November 19, 2026 21:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
v2/partial-field-ids-parquet-data: a table withschema.name-mapping.defaultset and one Parquet data file that carries field IDs on its top-level columns and struct fields but not on its list element, map key or map value. It is the companion to #14 for the case the dev@ thread is discussing.Following CONTRIBUTING's "Cases the spec has not settled", the PR holds the input only: no
expected/scan.jsonand noindex.jsonentry. The table README names the open question and states, as prose, what the Column Projection section already fixes. It stays a draft until the thread settles.The first commit lets
GenerateTables.javaset table properties and write a data file with its own schema through parquet-mr, since Iceberg's writer always writes every field ID.Current readers differ on this file:
IcebergGenerics) reads fields 1, 2, 3, 7, 8 and 6 as the README states, and fails with "is not in the store" on any projection that includestagsorprops.id, name, location, added, with "cannot convert element ... missing field_id". ItshasIDscheck intable/arrow_utils.gotreats the file as fully ID'd because it does not look below a field that has an ID._HasIdscheck is unchanged on main at 33b4ce51) fails on every projection with "Could not find field with name: c4.element". It finds a field without an ID, applies the name mapping to the whole file, and the mapping does not list thec*names.tagsas lists of the right length with every element null, and fails onpropsbecause the required key (field 10) "is missing from the file schema".So the four readers give four different results, and only two of them agree with the values the README says the spec already fixes.