Repository navigation
fix(arrow): filter absent nullable columns in ordered comparisons #3508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mattfaltyn
wants to merge
4
commits into
apache:main
Choose a base branch
from
mattfaltyn:fix/missing-null-comparisons
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+277
−7
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
506145e
fix(arrow): filter absent nullable columns in ordered comparisons
mattfaltyn 90649d6
fix(arrow): handle missing nulls in negated predicates
mattfaltyn cca7204
Merge branch 'main' into fix/missing-null-comparisons
mattfaltyn 0c489ee
Merge branch 'main' into fix/missing-null-comparisons
mattfaltyn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not_inandnot_starts_withstill returnbuild_always_true()for a missing nullable column. On this branchb NOT IN ('x', 'y')andb NOT STARTS WITH 'x'give 3 rows whenbis missing from the file and 0 when it's stored as NULL. Same mismatch as<, so maybe worth covering here, or a follow-up?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this! Both predicates now treat an absent nullable column like a stored NULL. I added Parquet regression coverage, and the local Rust and Python suites passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-ran my probe on 90649d6.
NOT INandNOT STARTS WITHnow give 0 rows for the missing column, same as the stored-NULL file.NOT (b < 'm'),IS NULLandIS NOT NULLmatch too. LGTM.