Repository navigation
perf(arrow): build the delete row selection from deleted ranges #3454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
laskoviymishka
merged 4 commits into
apache:main
from
JeonDaehong:perf-dv-range-row-selection
Oct 23, 2026
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
46ff84f
perf(arrow): build the delete row selection from deleted ranges
JeonDaehong 1820b84
Address review: fix advance_to (#3400), randomized reader test
JeonDaehong 0bc58a0
Address review: deletes past the file end, runs across 2^16, ranges()…
JeonDaehong 743ae53
Use a seeded StdRng in the model tests and cover empty row groups
JeonDaehong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd add a randomized test for
build_deletes_row_selectionnext to this one: random row-group sizes, a randomselected_row_groupssubset and the DVs frommixed_delete_vectors, compared against a per-row oracle that run-length-encodes the selected groups.The iterator gets a model test, but this loop was rewritten wholesale and only has hand-picked cases. The branch I'd least trust to stay correct is a range carried from a selected row group into a skipped one.
mixed_delete_vectorswould need to bepub(crate)undercfg(test)for this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
test_build_deletes_row_selection_matches_model: random row-group cuts (half placed next to a deleted position so they land inside runs), a randomselected_row_groupssubset orNone, over every DV frommixed_delete_vectors(nowpub(crate)undercfg(test)), compared with a selection built one deleted position at a time. Dropping the "range continues into the next row group" break, or skipping one row too far in a skipped group, makes it fail.