Repository navigation
feat(rest): add a SigV4 request signer #3082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
b3e291e
feat(rest): add a SigV4 request signer
plusplusjiajia 1ad8e0e
fix(rest): mute aws-sigv4 tracing and tighten payload hashing
plusplusjiajia 53e5c90
refactor(rest): take credentials per call, as Java's signer does
plusplusjiajia 3e252bd
docs(rest): trim the SigV4 signer comments
plusplusjiajia fc32f42
refactor(rest): break sign_at into named steps
plusplusjiajia 89d8f3f
docs(rest): state the redirect and log-always limits of the signer
plusplusjiajia 26bf79d
fix(rest): keep relocation headers out of the signature, and the trac…
plusplusjiajia 8edf544
docs(rest): name the log bridge that stays unmuted
plusplusjiajia df66c94
docs(rest): log-always also bypasses the muted subscriber
plusplusjiajia b9fa6cb
fix(rest): return an error instead of unwrapping the content hash header
plusplusjiajia 5d6b772
refactor(rest): make PayloadHashMode non_exhaustive and SigV4Signer::…
plusplusjiajia f147293
docs(rest): note the base64 header quirk and credential freshness
plusplusjiajia b205a40
docs(rest): keep the plus note next to the rewrite it explains
plusplusjiajia 14e0f05
fix(rest): spell out the headers Java leaves unsigned
plusplusjiajia 44033c9
test(rest): check signatures against Iceberg Java
plusplusjiajia 0f02a72
test(rest): pin the signing tests to a fixed time
plusplusjiajia 5aab197
test(rest): check standard mode against the AWS test suite
plusplusjiajia 22af036
test(rest): drop the helper-only AWS vector and the hmac dev-dependency
plusplusjiajia 9e9ff82
fix(rest): decide the tracing mute with public tracing API
plusplusjiajia c36c457
docs(rest): tighten the payload hash and credential notes
plusplusjiajia 2e6f507
test(rest): bound the live-clock stamp by readings around the call
plusplusjiajia 7824a3b
chore(rest): update the public API for the signer changes
plusplusjiajia aba93f6
docs(rest): simplify the SigV4 signer comments
plusplusjiajia e241d07
refactor(rest): build SigV4Signer with a typed builder
plusplusjiajia ee1a9fc
fix(rest): propagate a failed userinfo strip instead of signing the U…
plusplusjiajia 7a79bfc
docs(rest): name the flag the tracing mute is gated to avoid
plusplusjiajia edc9d36
docs(rest): say that as_bytes merges an absent body with an empty one
plusplusjiajia b367eb3
chore(rest): update the public API for the signer builder
plusplusjiajia 0dab39c
fix(rest): validate requests before signing
plusplusjiajia 693de9d
fix(rest): address SigV4 review findings
plusplusjiajia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think AWS-specific dependencies are worth to hide behind a feature flag like we already do for different FileIO deps with OpenDAL
iceberg-rust/crates/storage/opendal/Cargo.toml
Lines 30 to 48 in a5f162f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DerGut Good point, this wasn't on my radar. Added —
sigv4, off by default, gatingaws-sigv4,aws-credential-types,base64andsha2.