You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Test an overwrite retry whose base moves between attempts #3612
Is your feature request related to a problem or challenge?
The retry test in #3300 (test_overwrite_retry_keeps_its_snapshot_id_and_never_reuses_a_manifest_path) runs every attempt against the same base, so it never exercises the part of OverwriteAction::commit that has to redo work when the table moved: re-reading the manifests of the new base, re-checking that every requested delete is still live, and re-running the duplicate check against files a concurrent commit may have added.
A transaction-level test where a concurrent commit lands between the first and second attempt, covering both outcomes: the retry succeeds when the deleted files are still live in the new base, and fails with the missing-files error when the concurrent commit removed one of them. The same shape fits FastAppendAction and the rewrite action from #3585 once those share the retry path.
Activity