Skip to content

Expose the delete_vector module so engines with their own Parquet reader can decode deletion vectors #3460

Closed

Description

@giladkl

Is your feature request related to a problem or challenge?

We are adding Iceberg format version 3 support to an engine that uses this crate for the catalog and table metadata but reads Parquet with a reader of its own, so it does not go through iceberg::scan / ArrowReader. To apply deletion vectors it has to decode the deletion-vector-v1 Puffin blobs itself.

The crate already has that decoder: DeleteVector::deserialize (#2866), with the validation of the length prefix, CRC, magic and key order. But delete_vector is a private module (mod delete_vector; in lib.rs, no re-export), so the type is unreachable from outside the crate, and we ended up duplicating the decoder.

Describe the solution you'd like

Make delete_vector a public module, the way puffin already is (it exports DELETION_VECTOR_V1, PuffinReader and PuffinWriter, i.e. the container around the vector but not the vector itself). That exposes DeleteVector, DeleteVectorIterator and DeleteVector::deserialize to engines that read deletion vectors through their own Parquet path. The public items need doc comments to satisfy the crate's deny(missing_docs), and public-api.txt needs regenerating.

Willingness to contribute

I can contribute to this feature independently.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions