Skip to content

Core: Default writes to merge append - #4453

Open
Anurag-S1ngh wants to merge 1 commit into
apache:mainfrom
Anurag-S1ngh:feat/3741-default-merge-append
Open

Anurag-S1ngh wants to merge 1 commit into
apache:mainfrom
Anurag-S1ngh:feat/3741-default-merge-append

Conversation

@Anurag-S1ngh

Copy link
Copy Markdown
Contributor

Rationale for this change

PyIceberg defaulted to fast append, which adds manifest metadata on every commit. The devlist discussion concluded that merge append is the better default for metadata management, and the earlier change was intentionally deferred until after the 0.12 release.

Default commit.manifest-merge.enabled to true. Fast append remains available per table by setting it to false. The documentation now describes both modes.

Are these changes tested?

Yes. Two unit tests assert the default and the opt-out. The manifest merge integration test now relies on the default for the merge case and disables merging explicitly for the fast append case. The partitioned overwrite test no longer depends on file order. tests/table passes.

Are there any user-facing changes?

Yes. New writes use merge append by default. Tables that want the previous behavior set commit.manifest-merge.enabled to false. This should be called out in the release notes.

Merge append keeps manifest metadata compact instead of adding a manifest
list entry per commit. Python metadata writes are slower than in other
clients, so fast append remains available by setting
commit.manifest-merge.enabled to false.

Update the documentation and the tests that relied on the old default.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant