Repository navigation
Core: Default writes to merge append - #4453
Open
Anurag-S1ngh wants to merge 1 commit into
Open
Anurag-S1ngh wants to merge 1 commit into
Anurag-S1ngh wants to merge 1 commit into
Conversation
Merge append keeps manifest metadata compact instead of adding a manifest list entry per commit. Python metadata writes are slower than in other clients, so fast append remains available by setting commit.manifest-merge.enabled to false. Update the documentation and the tests that relied on the old default.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
PyIceberg defaulted to fast append, which adds manifest metadata on every commit. The devlist discussion concluded that merge append is the better default for metadata management, and the earlier change was intentionally deferred until after the 0.12 release.
Default
commit.manifest-merge.enabledto true. Fast append remains available per table by setting it to false. The documentation now describes both modes.Are these changes tested?
Yes. Two unit tests assert the default and the opt-out. The manifest merge integration test now relies on the default for the merge case and disables merging explicitly for the fast append case. The partitioned overwrite test no longer depends on file order.
tests/tablepasses.Are there any user-facing changes?
Yes. New writes use merge append by default. Tables that want the previous behavior set
commit.manifest-merge.enabledtofalse. This should be called out in the release notes.