Skip to content

Tests: Enumerate Arrow and Iceberg primitive type conversions - #4448

Open
Anurag-S1ngh wants to merge 1 commit into
apache:mainfrom
Anurag-S1ngh:test/3714-pyarrow-type-matrix
Open

Anurag-S1ngh wants to merge 1 commit into
apache:mainfrom
Anurag-S1ngh:test/3714-pyarrow-type-matrix

Conversation

@Anurag-S1ngh

Copy link
Copy Markdown
Contributor

Rationale for this change

The conversion tests were written one type at a time, which makes it easy to miss a type when one is added. Add table-driven tests that cover every supported primitive Arrow type, every unsupported one, and the round trip for every primitive Iceberg type.

Are these changes tested?

These are tests. tests/io/test_pyarrow_visitor.py passes.

Are there any user-facing changes?

No.

Add table-driven tests that cover every supported primitive Arrow type,
every unsupported type, and the round trip for every primitive Iceberg
type. This makes the conversion matrix explicit instead of relying on
per-type tests that are easy to miss when a type is added.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant