Repository navigation
Tests: Enumerate Arrow and Iceberg primitive type conversions - #4448
Open
Anurag-S1ngh wants to merge 1 commit into
Open
Anurag-S1ngh wants to merge 1 commit into
Anurag-S1ngh wants to merge 1 commit into
Conversation
Add table-driven tests that cover every supported primitive Arrow type, every unsupported type, and the round trip for every primitive Iceberg type. This makes the conversion matrix explicit instead of relying on per-type tests that are easy to miss when a type is added.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The conversion tests were written one type at a time, which makes it easy to miss a type when one is added. Add table-driven tests that cover every supported primitive Arrow type, every unsupported one, and the round trip for every primitive Iceberg type.
Are these changes tested?
These are tests.
tests/io/test_pyarrow_visitor.pypasses.Are there any user-facing changes?
No.