Repository navigation
fix: поддержать upsert после добавления столбца - #4444
Draft
ViktorBystrov72 wants to merge 1 commit into
Draft
ViktorBystrov72 wants to merge 1 commit into
ViktorBystrov72 wants to merge 1 commit into
Conversation
Co-authored-by: gpt-6.2-sol <noreply@openai.com>
Contributor
|
@ViktorBystrov72 Thanks for raising this PR, could you update the PR description te English? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Задача
Closes #3105
Изменение
Для
upsertPyIceberg читает выбранный снимок по текущим типам полей. При сравнении он учитывает переданные поля по Iceberg ID, в том числе вложенные. Это поддерживает добавление nullable-полей, переименование и повторное добавление поля с тем же именем. Для записи используются исходные строки.Проверки
Прошли 35 тестов
test_upsert.pyи 25 проверок совместимости и проекции схем. Регрессии покрывают веткиmainиdev, расширение типа ключа, частичную схему и смену ID. Ruff иgit diff --checkпрошли.AI Disclosure
Код и тесты подготовлены с помощью Codex, модель gpt-6.2-sol. Независимое локальное ревью проверило проекцию снимка и сравнение по ID. Черновик оставляет автору возможность лично проверить правила сравнения вложенных значений и заполнения полей перед отправкой на ревью сопровождающим.