Repository navigation
Conversation
Agents had no instruction to validate behavior against the spec, or to fall back to the Java implementation where the spec is ambiguous.
|
|
||
| ### Spec Compliance | ||
|
|
||
| <!-- markdown-link-check-disable-next-line --> |
There was a problem hiding this comment.
Any reason for disabling the Markdown link checker?
There was a problem hiding this comment.
Good catch, there's no need for it here. The link-check comments are meant for the docs site, and these are stable GitHub URLs that the checker should cover. I've removed them.
| ### Spec Compliance | ||
|
|
||
| <!-- markdown-link-check-disable-next-line --> | ||
| - The [Iceberg spec](https://github.com/apache/iceberg/blob/main/format/spec.md) is the source of truth. Check changes to metadata, manifests, schemas, partitioning, transforms, or the commit path against it, and cite the relevant section when behavior is non-obvious. |
There was a problem hiding this comment.
We could potentially make that list larger (include work involving the catalogs?) and maybe even just tell the agents to always look at the Java reference implementation for any changes.
There was a problem hiding this comment.
Agreed. I've broadened the Java bullet so it covers every change, including catalog work. I also added a bullet pointing REST catalog changes (pyiceberg/catalog/rest/) at the REST catalog OpenAPI spec.
… guidance Co-authored-by: Isaac <no-reply@databricks.com>
Rationale for this change
Agents had no instruction to validate behavior against the spec, or to fall back to the Java implementation where the spec is ambiguous.
Are these changes tested?
Are there any user-facing changes?