Repository navigation
Conversation
Contributor
Author
|
CC: @laskoviymishka |
laskoviymishka
self-requested a review
November 19, 2026 18:52
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Widen float32 partition values to float64 when building the spec-aware key that equality-delete cleanup uses to look up surviving data files.
Why
After an identity partition source is promoted from float to double, data files written before the promotion decode the partition value as float32 and equality deletes written after it carry float64. The survivor key printed
1000=1.1while the delete key printed1000=1.100000023841858, soDecideDeadEqualityDeletesWithSpecsfound no surviving file and classified a delete that still applies as dead. Compaction then drops that delete and the rows it covered come back: the newTestCompactionKeepsEqualityDeleteAfterFloatPartitionSourcePromotioncompacts two unrelated files and reads ids[1 2 3 4]on main instead of[2 3 4].The opposite case was wrong too: a float32
1.1data file and a double1.1delete printed the same key and matched, although they are different partitions after the promotion. That case only kept a dead delete around.This is the same root cause as #2605 and #2610 (fixed for scan delete matching in #2620) and the partitions table fix in #2637, in a code path neither of them touches.
Implementation
SurvivorSurvey.PartMinSeqandappendPartitionTuplekeep theirfmt-compatible output, so the exported survey layout and its keys do not change.Tests
TestCompactionKeepsEqualityDeleteAfterFloatPartitionSourcePromotion(v2 and v3): end to end through a rewrite. Fails on main.TestDecideDeadEqualityDeletesWithSpecs_Predicate: a survivor written before the promotion keeps the delete alive, and a different double value no longer matches. Both fail on main.commitPartitionedEqualityDeletesinpartition_promotion_deletes_test.gonow holds the equality-delete commit both promotion tests use.float32(1.1)inTestAppendPartitionTupleMatchesFmt, which fails if the exported keys were widened.