Repository navigation
refactor(table)!: move table/substrait to table/internal/substrait - #2649
Open
laskoviymishka wants to merge 1 commit into
Open
laskoviymishka wants to merge 1 commit into
laskoviymishka wants to merge 1 commit into
Conversation
ConvertExpr, ConvertSchema and NewExtensionSet return substrait-go v8 and arrow compute/exprs types, which pins those third-party types into the exported API. The package is only used inside table, so move it under table/internal with its tests, benchmark and the embedded functions_set.yaml, and update the four importing files in table. This is a pure move: package name, code and behavior are unchanged. Code importing table/substrait no longer compiles and there is no replacement. substrait-go stays a module dependency because table still uses it internally. Signed-off-by: laskoviymishka <laskoviymishka@gmail.com>
laskoviymishka
marked this pull request as ready for review
November 19, 2026 15:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves
table/substraittotable/internal/substrait, soConvertExpr,ConvertSchemaandNewExtensionSet, and the substrait-go v8 and arrowcompute/exprstypes they return, are no longer part of the exported API. It is item 8 on the v1 list, agreed in #2062 (comment). The files move unchanged, including the tests and the embeddedfunctions_set.yaml. Only the import path changes inarrow_filter_plan.go,arrow_scanner.go,transaction.goandtransaction_delete.go. Filtering, scans and deletes behave the same.releases.mdgets a compatibility note, since importers oftable/substraitwill no longer compile.go build ./...,go vet ./...andgo test ./table/...pass, and the moved substrait tests run from their new location.The existing unreleased note about
ConvertExprdroppingcaseSensitivenow describes a function nobody can call. I left it alone to keep this a pure move.Part of #2062.