Skip to content

refactor(table)!: move table/substrait to table/internal/substrait - #2649

Open
laskoviymishka wants to merge 1 commit into
apache:mainfrom
laskoviymishka:factory/substrait-internal
Open

laskoviymishka wants to merge 1 commit into
apache:mainfrom
laskoviymishka:factory/substrait-internal

Conversation

@laskoviymishka

Copy link
Copy Markdown
Contributor

This moves table/substrait to table/internal/substrait, so ConvertExpr, ConvertSchema and NewExtensionSet, and the substrait-go v8 and arrow compute/exprs types they return, are no longer part of the exported API. It is item 8 on the v1 list, agreed in #2062 (comment). The files move unchanged, including the tests and the embedded functions_set.yaml. Only the import path changes in arrow_filter_plan.go, arrow_scanner.go, transaction.go and transaction_delete.go. Filtering, scans and deletes behave the same. releases.md gets a compatibility note, since importers of table/substrait will no longer compile.

go build ./..., go vet ./... and go test ./table/... pass, and the moved substrait tests run from their new location.

The existing unreleased note about ConvertExpr dropping caseSensitive now describes a function nobody can call. I left it alone to keep this a pure move.

Part of #2062.

AI-assisted, reviewed by a human.

ConvertExpr, ConvertSchema and NewExtensionSet return substrait-go v8
and arrow compute/exprs types, which pins those third-party types into
the exported API. The package is only used inside table, so move it
under table/internal with its tests, benchmark and the embedded
functions_set.yaml, and update the four importing files in table.

This is a pure move: package name, code and behavior are unchanged.
Code importing table/substrait no longer compiles and there is no
replacement. substrait-go stays a module dependency because table
still uses it internally.

Signed-off-by: laskoviymishka <laskoviymishka@gmail.com>
@laskoviymishka
laskoviymishka marked this pull request as ready for review November 19, 2026 15:04

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant