Skip to content

refactor!: fix the remaining initialisms in exported names - #2648

Open
laskoviymishka wants to merge 1 commit into
apache:mainfrom
laskoviymishka:factory/initialism-renames
Open

laskoviymishka wants to merge 1 commit into
apache:mainfrom
laskoviymishka:factory/initialism-renames

Conversation

@laskoviymishka

Copy link
Copy Markdown
Contributor

This renames the last exported names that break Go initialism style, following #2307 and #2310: table.PropertyUuid and table.PropertyCurrentSnapshotId become PropertyUUID and PropertyCurrentSnapshotID, table.ReassignedIds becomes ReassignedIDs, the table.WriteTask.Uuid field becomes UUID, glue.CatalogIdKey becomes CatalogIDKey, io.ADLSSasTokenPrefix becomes ADLSSASTokenPrefix, and rest.Oauth2AuthManager and rest.NewOauth2AuthManager become OAuth2AuthManager and NewOAuth2AuthManager, matching AuthTypeOAuth2 and WithOAuthToken. Callers, tests and the website docs are updated, and releases.md gets a compatibility note.

Property strings, config keys and JSON are unchanged, so nothing changes on the wire. There are no deprecated aliases, as in the earlier rename PRs. The only visible text change is the nil-source panic message, which now names NewOAuth2AuthManager.

It's a pure rename, so there are no new tests. The existing tests use the new names, and a search finds no old names outside the release note.

Part of #2062.

AI-assisted, reviewed by a human.

Rename the last exported identifiers that break Go initialism style,
following apache#2307 and apache#2310:

  table.PropertyUuid              -> table.PropertyUUID
  table.PropertyCurrentSnapshotId -> table.PropertyCurrentSnapshotID
  table.ReassignedIds             -> table.ReassignedIDs
  table.WriteTask.Uuid            -> table.WriteTask.UUID
  glue.CatalogIdKey               -> glue.CatalogIDKey
  io.ADLSSasTokenPrefix           -> io.ADLSSASTokenPrefix
  rest.Oauth2AuthManager          -> rest.OAuth2AuthManager
  rest.NewOauth2AuthManager       -> rest.NewOAuth2AuthManager

The OAuth2 names now match AuthTypeOAuth2 and WithOAuthToken. Callers,
tests, doc comments, the nil-source panic message and the website docs
are updated. Property strings, config keys, JSON and unexported names
are unchanged, and no deprecated aliases are kept.

Signed-off-by: laskoviymishka <laskoviymishka@gmail.com>
@laskoviymishka
laskoviymishka marked this pull request as ready for review November 19, 2026 15:04

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant