Repository navigation
refactor!: fix the remaining initialisms in exported names - #2648
Open
laskoviymishka wants to merge 1 commit into
Open
laskoviymishka wants to merge 1 commit into
laskoviymishka wants to merge 1 commit into
Conversation
Rename the last exported identifiers that break Go initialism style, following apache#2307 and apache#2310: table.PropertyUuid -> table.PropertyUUID table.PropertyCurrentSnapshotId -> table.PropertyCurrentSnapshotID table.ReassignedIds -> table.ReassignedIDs table.WriteTask.Uuid -> table.WriteTask.UUID glue.CatalogIdKey -> glue.CatalogIDKey io.ADLSSasTokenPrefix -> io.ADLSSASTokenPrefix rest.Oauth2AuthManager -> rest.OAuth2AuthManager rest.NewOauth2AuthManager -> rest.NewOAuth2AuthManager The OAuth2 names now match AuthTypeOAuth2 and WithOAuthToken. Callers, tests, doc comments, the nil-source panic message and the website docs are updated. Property strings, config keys, JSON and unexported names are unchanged, and no deprecated aliases are kept. Signed-off-by: laskoviymishka <laskoviymishka@gmail.com>
laskoviymishka
marked this pull request as ready for review
November 19, 2026 15:04
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the last exported names that break Go initialism style, following #2307 and #2310:
table.PropertyUuidandtable.PropertyCurrentSnapshotIdbecomePropertyUUIDandPropertyCurrentSnapshotID,table.ReassignedIdsbecomesReassignedIDs, thetable.WriteTask.Uuidfield becomesUUID,glue.CatalogIdKeybecomesCatalogIDKey,io.ADLSSasTokenPrefixbecomesADLSSASTokenPrefix, andrest.Oauth2AuthManagerandrest.NewOauth2AuthManagerbecomeOAuth2AuthManagerandNewOAuth2AuthManager, matchingAuthTypeOAuth2andWithOAuthToken. Callers, tests and the website docs are updated, and releases.md gets a compatibility note.Property strings, config keys and JSON are unchanged, so nothing changes on the wire. There are no deprecated aliases, as in the earlier rename PRs. The only visible text change is the nil-source panic message, which now names
NewOAuth2AuthManager.It's a pure rename, so there are no new tests. The existing tests use the new names, and a search finds no old names outside the release note.
Part of #2062.