Repository navigation
feat: add table-aware position delete updates - #919
Open
wirybeaver wants to merge 3 commits into
Open
wirybeaver wants to merge 3 commits into
wirybeaver wants to merge 3 commits into
Conversation
wirybeaver
force-pushed
the
feature/v3-dv-write-pipeline
branch
from
September 5, 2026 21:59
e6db958 to
c11cea2
Compare
wirybeaver
force-pushed
the
feature/v3-dv-write-pipeline
branch
from
September 5, 2026 22:21
c11cea2 to
477a2ff
Compare
4 tasks
wirybeaver
force-pushed
the
feature/v3-dv-write-pipeline
branch
from
October 1, 2026 19:57
477a2ff to
658315c
Compare
wirybeaver
force-pushed
the
feature/v3-dv-write-pipeline
branch
from
October 1, 2026 21:45
658315c to
f256e78
Compare
Member
|
@wirybeaver is this ready for review? |
wirybeaver
marked this pull request as ready for review
November 20, 2026 07:25
wirybeaver
force-pushed
the
feature/v3-dv-write-pipeline
branch
from
November 20, 2026 07:32
f43d28c to
2bd9494
Compare
Author
|
Hi, @zhjwpku feel free to take a review. I rebase the most recent and updated the PR body |
Member
CI failed, please take a look when available, thanks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DV-PR-1 in #916 lets callers delete a row by data file and position. A second delete on the same v3 file must preserve positions deleted by the first commit.
Modification
Resolve each live file's partition and spec, and check the requested positions against its record count before creating output. Commit through
RowDelta, which validates that the referenced data files still exist.A definite commit failure cleans up generated files. An unknown commit outcome preserves them because the catalog may already reference them.
Test
The in-library end-to-end test uses real Parquet and Puffin encoding with Arrow MockFileSystem and InMemoryCatalog.