You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Move GTest and Google Benchmark setup into IcebergThirdpartyToolchain #829
GTest dependency setup currently lives in src/iceberg/test/CMakeLists.txt, and the new Google Benchmark setup in #825 follows the same local pattern in src/iceberg/benchmark/CMakeLists.txt.
Review feedback on #825 suggested moving this dependency setup into IcebergThirdpartyToolchain.cmake instead.
Proposal
Move both GTest and Google Benchmark CMake dependency setup into cmake_modules/IcebergThirdpartyToolchain.cmake, so third-party dependency resolution is kept in one place.
Notes
This should be handled as a separate cleanup from #825, since #825 is only adding the benchmark build scaffolding and intentionally follows the existing GTest pattern.
Activity
build: move GTest and Google Benchmark setup into IcebergThirdpartyTo…