Fix Some(null) in ExpressionConverter bypassing expression transformation fallback#11757
Open
acvictor wants to merge 1 commit intoapache:mainfrom
Open
Fix Some(null) in ExpressionConverter bypassing expression transformation fallback#11757acvictor wants to merge 1 commit intoapache:mainfrom
acvictor wants to merge 1 commit intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
@baibaichen can you please review this PR? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR replaces
Noneon the default case, so getOrElse correctly falls through.Currently,
tryTransformWithoutExpressionMappingreturnsSome(null)for unmatched expressions instead ofNoneand the caller does.getOrElse { transformExpression(...) }. Since Some(null).getOrElse(fallback) returns null without invoking the fallback, some paths can silently get a null transformer which will lead to a downstream NPE.How was this patch tested?
Existing UTs.
Was this patch authored or co-authored using generative AI tooling?
No