Skip to content

[VL] Close ColumnarBatch in ColumnarCollectLimitExec for skipped and sliced batches #11754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
acvictor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[VL] Close ColumnarBatch in ColumnarCollectLimitExec for skipped and sliced batches #11754

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion backends-velox/src/main/scala/org/apache/gluten/execution/ColumnarCollectLimitExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ case class ColumnarCollectLimitExec(

if (rowsToSkip >= batchSize) {
rowsToSkip -= batchSize
batch.close()
} else {
val startIndex = rowsToSkip
val leftoverAfterSkip = batchSize - startIndex
Expand All @@ -82,7 +83,9 @@ case class ColumnarCollectLimitExec(
ColumnarBatches.retain(batch)
batch
} else {
VeloxColumnarBatches.slice(batch, startIndex, needed)
val sliced = VeloxColumnarBatches.slice(batch, startIndex, needed)
Copy link
Contributor

@jinchengchenghh jinchengchenghh Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sliced calls velox slice API, reuse buffers of batch, so we cannot close it.

batch.close()
sliced
}

rowsToCollect -= needed
Expand Down
Loading