Empty JSON array should return empty list views instead of null#19
Open
csaboka wants to merge 1 commit intoapache:trunkfrom
Open
Empty JSON array should return empty list views instead of null#19csaboka wants to merge 1 commit intoapache:trunkfrom
csaboka wants to merge 1 commit intoapache:trunkfrom
Conversation
rmannibucau
approved these changes
Jul 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of
getValuesAs()returns null. This is unexpected, since empty collections should return empty views instead of null. I imagine there are people who pass this call to an enhanced for loop without an extra null check, so this seems dangerous as well.