Conversation
|
Hi @opeti, thanks for the patch. I wonder what triggers this patch? Keeping the impl working with JAX-RS 2.0 is nice for now IMHO (jaxrs is used in scope provided so we don't control it more than >= 2.0 and some environment can be slow to upgrade). Any immediate need? |
|
Hello! Well, I'm using PATCH operations in my api and since I use Resteasy and not Apache CXF, I was not able to generate OpenAPI documentation unless I included the CXF dependency. After that the PATCH operations were not documented, because I use JAX-RS 2.1 annotations, and JAX-RS finally got its own PATCH annotation in this version. So I had to modify the implementation of your OpenAPI generator. In my opinion it a good way to use the specification where it is possible, but on the other side I can agree with you that maybe JAX-RS 2.1 is not widely adopted yet, so maybe this this change is little early. |
|
Hmm the fallback was using @HttpMethod to grab verb extension, did you check if the api was missing it or it was a bug in that area in the annotation processor? We clearly want patch to work, even if we need some reflection |
|
FYI I created https://issues.apache.org/jira/browse/GERONIMO-6694 and will tackle that with the fallback using @HttpMethod to avoid to depend on jaxrs 2.1 and break some users if that's ok for you |
|
Ok, I leave the decision to you. It is just unfonfortable for me, that if I use PATCH methods via annotation from JAX-RS 2.1, then I have to include Apache CXF dependency too just to be able to generate the OpenApi documentation. But I understand that upgrading JAX-RS version could breake more users, so I can live with this situation for now. |
|
@opeti it is no more an issue on master, was a completion (human ;)) bug niw fixed but it was designed to work - same for TRACE - with jaxrs API. |
3 participants
No description provided.