Skip to content

[FLINK-41193][checkpointing] Disable checkpointing during recovery when aligned-checkpoint-timeout > 0 - #29596

Merged
1996fanrui merged 1 commit into
apache:masterfrom
1996fanrui:FLINK-41193
Oct 26, 2026
Merged

1996fanrui merged 1 commit into
apache:masterfrom
1996fanrui:FLINK-41193

Conversation

@1996fanrui

Copy link
Copy Markdown
Member

What is the purpose of the change

Checkpointing during recovery crashes the task when execution.checkpointing.aligned-checkpoint-timeout > 0 (see FLINK-40526). As the proper fix is non-trivial, this PR temporarily disables checkpointing during recovery in this case.

Brief change log

  • CheckpointingOptions#isCheckpointingDuringRecoveryEnabled returns false when aligned-checkpoint-timeout > 0, with a TODO referencing FLINK-40526
  • Document the limitation in execution.checkpointing.during-recovery.enabled and regenerate the config docs

Verifying this change

  • Extended CheckpointingOptionsTest#testIsCheckpointingDuringRecoveryEnabled to cover a positive aligned checkpoint timeout

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: Claude Opus 5.5

@1996fanrui 1996fanrui left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RocMarshal , could you please help take a look this pr when you are available? thanks

@flinkbot

flinkbot commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@RocMarshal RocMarshal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @1996fanrui

@1996fanrui

Copy link
Copy Markdown
Member Author

@RocMarshal

Copy link
Copy Markdown
Contributor

@1996fanrui

It was fixed by 80b0144

Would you mind having a try on rebasing the latest master then re-push ?

…en aligned-checkpoint-timeout > 0

Generated-by: Claude Opus 5.5
@1996fanrui

Copy link
Copy Markdown
Member Author

Thanks for the suggestion, it works. merging

@1996fanrui
1996fanrui merged commit 742220a into apache:master Oct 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants