Repository navigation
[FLINK-41193][checkpointing] Disable checkpointing during recovery when aligned-checkpoint-timeout > 0 - #29596
Merged
Merged
Conversation
1996fanrui
commented
Oct 25, 2026
1996fanrui
left a comment
Member
Author
There was a problem hiding this comment.
Hey @RocMarshal , could you please help take a look this pr when you are available? thanks
Collaborator
Member
Author
|
Hey @RocMarshal , is the CI failure caused by 2.4 branch cutting? |
Contributor
|
It was fixed by 80b0144 Would you mind having a try on rebasing the latest master then re-push ? |
…en aligned-checkpoint-timeout > 0 Generated-by: Claude Opus 5.5
1996fanrui
force-pushed
the
FLINK-41193
branch
from
October 26, 2026 09:07
d26e3f4 to
262f487
Compare
Member
Author
|
Thanks for the suggestion, it works. merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Checkpointing during recovery crashes the task when
execution.checkpointing.aligned-checkpoint-timeout> 0 (see FLINK-40526). As the proper fix is non-trivial, this PR temporarily disables checkpointing during recovery in this case.Brief change log
CheckpointingOptions#isCheckpointingDuringRecoveryEnabledreturns false whenaligned-checkpoint-timeout> 0, with a TODO referencing FLINK-40526execution.checkpointing.during-recovery.enabledand regenerate the config docsVerifying this change
CheckpointingOptionsTest#testIsCheckpointingDuringRecoveryEnabledto cover a positive aligned checkpoint timeoutDoes this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Opus 5.5