Skip to content

[test][python] Fix Action deserialize tests on release branch - #940

Merged
wenjin272 merged 1 commit into
apache:release-0.3from
wenjin272:fix-test
Jul 30, 2026
Merged

[test][python] Fix Action deserialize tests on release branch#940
wenjin272 merged 1 commit into
apache:release-0.3from
wenjin272:fix-test

Conversation

@wenjin272

Copy link
Copy Markdown
Contributor

What changed

  • Update two Action config deserialization test fixtures to use the
    release-0.3 field name, listen_event_types.

Why

PR #921 was authored against main, where the field is named
trigger_conditions. When that change was cherry-picked to release-0.3, the
new tests retained the main field name even though Action on the release
branch still accepts listen_event_types.

As a result, all Python unit-test matrix jobs failed before exercising the
intended config deserialization behavior:

TypeError: Action.__init__() got an unexpected keyword argument 'trigger_conditions'

This keeps the production implementation unchanged and adapts only the
branch-specific test fixtures.

Validation

  • python/.venv/bin/python -m pytest flink_agents/plan/tests/test_action.py -q
    • 7 passed
  • Full non-integration Python unit-test selection
    • 571 passed, 11 skipped, 122 deselected
  • ruff check and ruff format --check on the changed file
  • git diff --check

Use the release-0.3 listen_event_types field in the cherry-picked Action config deserialization tests.

Co-Authored-By: Codex <noreply@openai.com>
AI-Model: gpt-5
AI-Contributed/Feature: 0/0
AI-Contributed/UT: 4/4
@github-actions github-actions Bot added doc-label-missing The Bot applies this label either because none or multiple labels were provided. fixVersion/0.3.2 The feature or bug should be implemented/fixed in the 0.3.2 version. priority/major Default priority of the PR or issue. labels Jul 30, 2026
@wenjin272
wenjin272 marked this pull request as ready for review July 30, 2026 14:57
@wenjin272 wenjin272 added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing The Bot applies this label either because none or multiple labels were provided. labels Jul 30, 2026
@wenjin272
wenjin272 merged commit 18a94a1 into apache:release-0.3 Jul 30, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs fixVersion/0.3.2 The feature or bug should be implemented/fixed in the 0.3.2 version. priority/major Default priority of the PR or issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant