[hotfix] Ignore the local directories check-license.sh creates - #934
Open
weiqingy wants to merge 2 commits into
Open
[hotfix] Ignore the local directories check-license.sh creates#934weiqingy wants to merge 2 commits into
weiqingy wants to merge 2 commits into
Conversation
tools/check-license.sh creates two directories in the repository root before it runs: lib/ for the Apache RAT jar it downloads, and build/ for the scan results it writes. Neither was ignored, so running the license check left them as untracked entries in git status for every contributor. Both patterns are anchored to the root so nested directories of the same name keep matching their own existing rules.
Collaborator
Author
|
The one failing check is unrelated to this PR.
This PR only adds two lines to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of change
tools/check-license.shcreates two directories in the repository root before it runs:mkdir -p "$FWDIR"/lib(line 65) for the Apache RAT jar it downloadsmkdir -p build(line 72) for therat-results.txtit writesNeither was in
.gitignore, so anyone who runs the repository's own license check ends up with?? build/and?? lib/sitting ingit statusfrom then on.Both patterns are anchored to the root (
/build/,/lib/) so that nested directories of the same name keep matching their own existing rules. In particularpython/flink_agents/lib/still matches its own entry rather than the new one, and no tracked file is affected:git ls-files build libis empty.Tests
Not applicable, this only changes
.gitignore. Verified withgit check-ignore -v:After the change,
tools/check-license.shleaves a cleangit status.API
No.
Documentation
doc-neededdoc-not-neededdoc-included