-
Notifications
You must be signed in to change notification settings - Fork 2.3k
FINERACT-2003: Enforce password reset on first login #5387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
FINERACT-2003: Enforce password reset on first login #5387
Conversation
| </addColumn> | ||
| </changeSet> | ||
|
|
||
| <changeSet author="fineract" id="2" context="postgresql"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add a context for MariaDb?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Victor, thank you for the review!
I looked into this to be sure, and since the c_configuration table is defined with autoIncrement="true" in the initial schema, MariaDB and MySQL automatically handle the ID counter updates when we insert new rows.
The setval command included here is specifically to manually sync the PostgreSQL sequence, which doesn't update automatically in the same way. I believe we don't need an equivalent step for MariaDB, but please let me know if you'd prefer I handle it differently!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
IOhacker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@IOhacker I looked into the failed tests ,failures are in LoanDelayedScheduleCaptures and LoanMerchantIssuedRefund but these appear to be unrelated to the Authentication changes in this PR. could you please re-run them? |
2d8b6b9 to
cabcc33
Compare
|
@adamsaghy Happy to take reviews, if any |
Description
Implemented FINERACT-2003: Enforce password reset on first login.
This PR adds a configurable policy forcing users to change their password upon first login or after an admin reset.
Key Changes
password_reset_requiredcolumn tom_appuser. System usermifosis explicitly exempted.force-password-reset-on-first-loginglobal flag.PlatformUserDetailsCheckerto enforce the check post-authentication, replacing customDaoAuthenticationProviderinheritance.trueon User Creation and Admin Password Reset.falseon successful Self Password Change.PasswordResetRequiredException(HTTP 403) to signal the UI.Checklist