FINERACT-2421: Allow multiple interest rate schedule adjustments same date #5358
Conversation
| if (optLoanRescheduleRequest.isPresent()) { | ||
| LoanRescheduleRequest loanRescheduleRequest = optLoanRescheduleRequest.get(); | ||
| loanRescheduleRequest.reject(loanRescheduleRequest.getSubmittedByUser(), rescheduleFromDate); | ||
| loanRescheduleRequestRepository.save(loanRescheduleRequest); |
There was a problem hiding this comment.
I dont like this. This class is a validator, rejecting prior reschedules should not happen here!
There was a problem hiding this comment.
Also i dont think we should automatically reject is... it is misleading. Leave it APPROVED, but when we fetch these term variations, if the same applies to the same date, take the latter only.
Can it work?
There was a problem hiding this comment.
I think we need to do the following instead:
- We are not changing on the
LoanRescheduleRequest. It should reflect the original values!
If there is 2 same loan term variations, mark the existing one as isActive=false! Only the latter one will be active and in effect:
- Change interest rate from 2 February 2025 to 4%
- LoanRescheduleRequest is created with PENDING status, No Loan term variations created yet.
- Once its approved, loan term variation is created
- Change interest rate from 2 February 2025 to 5%
- LoanRescheduleRequest is created with PENDING status, No new Loan term variations created yet.
- Once its approved, we should check whether there is ACTIVE loan term variation with the same type and date and if so mark this as INACTIVE and create a new loan term variations with the new details.
There was a problem hiding this comment.
Code updated according to the details mentioned above. Thanks!
The ITC enriched to validate:
- Loan Reschedule Request status
- Loan Term Variants status
- Loan interest charged on each Loan Reschedule approve action
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Kindly see my concerns!
alberto-art3ch
force-pushed
the
FINERACT-2421/allow-multiple-schedule-adjustments-on-the-same-day-for-interest-change
branch
3 times, most recently
from
96ec11d to
f0eaf19
Compare
alberto-art3ch
force-pushed
the
FINERACT-2421/allow-multiple-schedule-adjustments-on-the-same-day-for-interest-change
branch
from
f0eaf19 to
27e5584
Compare
2 participants
Description
We need the ability to be able to adjust interest rates on a loan on the same day. Currently fineract allows only one interest rate change for a given day. If another interest rate needs to happen using the adjust-schedule api, we need to wait 1 more day before submitting the change.
It would be great to have a way to submit multiple adjust schedules on the same day and then have a way to determine which adjust schedule is currently active.
FINERACT-2421
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.