FINERACT-2421: Adjust interest with MIR and CBR results in improper allocations #5356
+148
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alberto-art3ch
force-pushed
the
FINERACT-2421/adjust-interest-on-account-with-mir-cbr-results-in-improper-allocations
branch
from
a94a897 to
a030150
Compare
adamsaghy
reviewed
Jan 21, 2026
| modifiedTransactions, unmodifiedTransactionIds); | ||
| final Money newAmount = interestBeforeRefund.minus(progCtx.getSumOfInterestRefundAmount()).minus(interestAfterRefund); | ||
| loanTransaction.updateAmount(newAmount.getAmount()); | ||
| loanTransaction.updateAmount(newAmount.abs().getAmount()); |
Contributor
There was a problem hiding this comment.
I cant imagine how this could be true... The interest cannot be higher than it was before the refund...
adamsaghy
requested changes
Jan 21, 2026
Contributor
adamsaghy
left a comment
adamsaghy
left a comment
There was a problem hiding this comment.
Kindly review my concern!
alberto-art3ch
force-pushed
the
FINERACT-2421/adjust-interest-on-account-with-mir-cbr-results-in-improper-allocations
branch
from
b49a834 to
b75522d
Compare
adamsaghy
reviewed
Jan 23, 2026
| @Override | ||
| @Transactional(readOnly = true, propagation = Propagation.REQUIRES_NEW) | ||
| public Money totalInterestByTransactions(LoanRepaymentScheduleTransactionProcessor processor, final Long loanId, | ||
| public Money totalInterestByTransactions(LoanRepaymentScheduleTransactionProcessor processor, final Loan loan, |
Contributor
There was a problem hiding this comment.
We cannot do this. The changes on the loan entity might be saved outside of this transactions which is unwanted behaviour!
alberto-art3ch
force-pushed
the
FINERACT-2421/adjust-interest-on-account-with-mir-cbr-results-in-improper-allocations
branch
from
b75522d to
5d8d95f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjust interest with a Loan Reschedule using the Interest Rate on account with MIR / CBR results in improper allocations on account
FINERACT-2421
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.