Repository navigation
fix(loans): distinguish unset optional repayment dates - #831
Merged
Aman-Mittal merged 1 commit intoOct 24, 2026
Merged
Aman-Mittal merged 1 commit into
Aman-Mittal merged 1 commit into
Conversation
Contributor
🔄 What this change talks toFrom the 1 application TypeScript file(s) changed in this pull request. sequenceDiagram
autonumber
participant LoanFormComponent as LoanFormComponent (Component)
participant PlatformDateService as PlatformDateService (Injected)
participant Router as Router (Injected)
participant LoanProductsService as LoanProductsService (API client)
participant Fineract as Fineract (REST API)
participant NotificationService as NotificationService (Injected)
participant LoansService as LoansService (API client)
participant MutationOutcomeService as MutationOutcomeService (Injected)
participant I18N as I18N (Injected)
LoanFormComponent->>PlatformDateService: today()
LoanFormComponent->>PlatformDateService: resolveToday()
LoanFormComponent->>Router: navigate()
LoanFormComponent->>LoanProductsService: getLoanproducts()
LoanProductsService->>Fineract: getLoanproducts()
Fineract-->>LoanProductsService: response
LoanFormComponent->>NotificationService: error()
LoanFormComponent->>LoanProductsService: getLoanproductsProductId()
LoanProductsService->>Fineract: getLoanproductsProductId()
Fineract-->>LoanProductsService: response
LoanFormComponent->>LoansService: getLoansLoanId()
LoansService->>Fineract: getLoansLoanId()
Fineract-->>LoansService: response
LoanFormComponent->>LoansService: putLoansLoanId()
LoansService->>Fineract: putLoansLoanId()
Fineract-->>LoansService: response
LoanFormComponent->>MutationOutcomeService: complete()
LoanFormComponent->>I18N: translate()
LoanFormComponent->>LoansService: postLoans()
LoansService->>Fineract: postLoans()
Fineract-->>LoansService: response
Generated by run 39939013215 from |
Contributor
E2E — mocked backend🎭 E2E Tests✅ All green — 431 passed · 0 failed · 1 skipped, across 42 spec files in 9m 2s. By spec file
All 432 tests — click to expand
Slowest 10 — what the shard counts should be tuned against
📼 Download the HTML report, videos and traces — see the Generated by run 39939013037 from |
Contributor
E2E — real Fineract🎭 E2E Tests✅ All green — 171 passed · 0 failed · 0 skipped, across 50 spec files in 12m 18s. By spec file
All 171 tests — click to expand
Slowest 10 — what the shard counts should be tuned against
📼 Download the HTML report, videos and traces — see the Generated by run 39939013037 from |
Aman-Mittal
approved these changes
Oct 24, 2026
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Create Loan now shows “Not set” for an empty Repayments Starting From Date instead of displaying today. A clear action restores the empty value, and a retry after a rejected create no longer sends a stale date that the user cleared.
Related to #793: this fixes its optional-date portion. Required markers and disabled-Save feedback remain open. Existing-record editing, date formatting and repayment calculations/defaults are unchanged.
Verification
Screenshots
The added spec saves focused selected/unset date-field screenshots and page screenshots/video in Playwright's output directory. Desktop and phone captures were inspected locally using synthetic fixtures.
AI assistance (optional)
Codex assisted with implementation and synthetic Vitest/Playwright verification.
Checklist