Repository navigation
fix(products): show repayment start date options - #768
Merged
Merged
Conversation
Aman-Mittal
reviewed
Oct 16, 2026
Contributor
Author
|
Addressed the review in signed commit d3dedf1. All six template-backed enum selects now share a |
Contributor
🔄 What this change talks toFrom the 1 application TypeScript file(s) changed in this pull request. sequenceDiagram
autonumber
participant LoanProductFormComponent as LoanProductFormComponent (Component)
participant FundsService as FundsService (API client)
participant Fineract as Fineract (REST API)
participant DelinquencyRangeAndBucketsManagementServ as DelinquencyRangeAndBucketsManagementService (API client)
participant LoanProductsService as LoanProductsService (API client)
participant Router as Router (Injected)
LoanProductFormComponent->>FundsService: getFunds()
FundsService->>Fineract: getFunds()
Fineract-->>FundsService: response
LoanProductFormComponent->>DelinquencyRangeAndBucketsManagementServ: getDelinquencyBuckets()
DelinquencyRangeAndBucketsManagementServ->>Fineract: getDelinquencyBuckets()
Fineract-->>DelinquencyRangeAndBucketsManagementServ: response
LoanProductFormComponent->>LoanProductsService: getLoanproductsTemplate()
LoanProductsService->>Fineract: getLoanproductsTemplate()
Fineract-->>LoanProductsService: response
LoanProductFormComponent->>LoanProductsService: getLoanproductsProductId()
LoanProductsService->>Fineract: getLoanproductsProductId()
Fineract-->>LoanProductsService: response
LoanProductFormComponent->>LoanProductsService: putLoanproductsProductId()
LoanProductsService->>Fineract: putLoanproductsProductId()
Fineract-->>LoanProductsService: response
LoanProductFormComponent->>Router: navigate()
LoanProductFormComponent->>LoanProductsService: postLoanproducts()
LoanProductsService->>Fineract: postLoanproducts()
Fineract-->>LoanProductsService: response
Generated by run 38880582180 from |
Contributor
E2E — mocked backend🎭 E2E Tests✅ All green — 412 passed · 0 failed · 1 skipped, across 40 spec files in 8m 12s. By spec file
All 413 tests — click to expand
Slowest 10 — what the shard counts should be tuned against
📼 Download the HTML report, videos and traces — see the Generated by run 38880583116 from |
Contributor
E2E — real Fineract🎭 E2E Tests✅ All green — 141 passed · 0 failed · 0 skipped, across 41 spec files in 10m 4s. By spec file
All 141 tests — click to expand
Slowest 10 — what the shard counts should be tuned against
📼 Download the HTML report, videos and traces — see the Generated by run 38880583116 from |
Aman-Mittal
approved these changes
Oct 17, 2026
Aman-Mittal
left a comment
Aman-Mittal
left a comment
Member
There was a problem hiding this comment.
LGTM with some minor issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Render the repayment start date option labels from the
valuefield returned by the live loan-product template, while retainingdescriptionas a compatibility fallback. The focused regression fixture now matches the real response shape and verifies both options are visible.Closes #759
Verification
npm test -- --watch=false --include='src/app/features/products/loan-product-form.component.test.ts'(35 passed)npm test -- --watch=false(2,113 passed across 299 files)npm run lintnpm run format:checknpm run i18n:checknpm run check:iconsnpm run check:a11y-namesnpm run check:template-textnpm run check:ui-primitivesnpm run api:surfacebash scripts/check-license.shnpm run buildThe regression test failed against the previous template binding with two empty labels and passes with this change. The production build retains the existing header component style-budget warning.
Screenshots
The issue contains the current broken UI screenshot; this change is covered by the DOM regression test.
Checklist
src/app/api/.