fix: reset cached batch in PageReadListener between sheets to avoid duplicate rows#961
Open
nkuprins wants to merge 1 commit into
Open
fix: reset cached batch in PageReadListener between sheets to avoid duplicate rows#961nkuprins wants to merge 1 commit into
nkuprins wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Closed: #960
PageReadListenerre-delivers the previous sheet's leftover rows when a single listener reads multiple sheets (doReadAll()) with a batch size greater than 1, so the consumer processes those rows twice.What's changed?
doAfterAllAnalysedflushes the partially filled batch at the end of each sheet, but kept the delivered rows incachedDataList. SinceDefaultAnalysisEventProcessor.endSheetinvokesdoAfterAllAnalysedafter every sheet and the same listener instance serves all sheets, the next sheet kept appending to the already-delivered list and re-emitted its rows as soon as the batch filled up.The fix is a one-line reset of
cachedDataListafter the end-of-sheet flush, mirroring whatinvokealready does after delivering a full batch.Regression test:
SimpleDataTest.pageReadListenerMultipleSheets07writes a two-sheet workbook (3 + 4 rows), reads all sheets with batch size 5, and asserts the exact delivered sequence. On currentmainit fails with sheet0's three rows delivered twice (10 deliveries instead of 7):Checklist